mlpack IRC logs, 2020-02-01

Logs for the day 2020-02-01 (starts at 0:00 UTC) are shown below.

February 2020
Sun
Mon
Tue
Wed
Thu
Fri
Sat
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
29
--- Log opened Sat Feb 01 00:00:42 2020
00:52 -!- UmarJ [~UmarJ@111.68.97.205] has quit [Ping timeout: 240 seconds]
00:54 -!- UmarJ [~UmarJ@111.68.97.205] has joined #mlpack
03:04 -!- UmarJ [~UmarJ@111.68.97.205] has quit [Ping timeout: 272 seconds]
03:51 < kartikdutt18Gitt> Hi @birm, Yes currently there 2 similar PR open and since one of them was about a year old with no recent commits, I sent another PR as I think I made more headway.
03:53 < kartikdutt18Gitt> *thought
08:30 -!- ayush29 [uid417807@gateway/web/irccloud.com/x-jrhpohlfaxjrevck] has quit [Quit: Connection closed for inactivity]
09:41 -!- ImQ009 [~ImQ009@unaffiliated/imq009] has joined #mlpack
09:51 -!- LakshyaOjhaGitte [gitterojha@gateway/shell/matrix.org/x-uzubirruegifhnmp] has joined #mlpack
09:51 < LakshyaOjhaGitte> Hi Everyone , I am Lakshya Ojha and I am currently a 3rd Year undergrad student at Delhi Technological University. I have been going through the code base for the couple of weeks and I would love to contribute to this organization.
09:52 < kartikdutt18Gitt> Hi @ojhalakshya, You should check out https://www.mlpack.org/community.html and https://www.mlpack.org/gsoc.html to get started.
10:31 < Param-29Gitter[m> Hello , I have made some changes in the codebase and i want to validate it before opening a PR. how do I do that..?
10:32 < HimanshuPathakGi> First you should try to build your changes
10:33 < Param-29Gitter[m> using make and make install?
10:33 < HimanshuPathakGi> locally
10:33 < HimanshuPathakGi> yse
10:34 < HimanshuPathakGi> *yes
10:34 < Param-29Gitter[m> and is there a way to make a single file?
10:35 < HimanshuPathakGi> You can skip building tests and cli and binding etc
10:36 < HimanshuPathakGi> But building single file is not possible
10:36 < Nakul[m]> > and is there a way to make a single file?
10:36 < Nakul[m]> you can do something like ```make your target```
10:37 < HimanshuPathakGi> (edited) But building single file is not possible => You can skip building tests and cli and python binding etc
10:37 < Param-29Gitter[m> @matrixbot so will make filename.hpp work?
10:38 < Nakul[m]> no in cmake you set your target and only that target you can make .
10:38 < Nakul[m]> can you tell where you made changes
10:39 < Param-29Gitter[m> in gini_gain.hpp
10:56 < Nakul[m]> i can't find target for this.ther is target for decision tree but not for this zoq i think for new cmake we should also consider to add target for all of the missing files
11:03 < Param-29Gitter[m> I ran make and sudo make install command to re-install mlpack. also what does bin/mlpack_test does? @matrixbot
11:05 < Nakul[m]> It builds all the tests file
11:06 < Nakul[m]> It will run all tests I will suggest you to run only those test that you have changed
11:07 < Param-29Gitter[m> So how should i check if the changes i made to the code actually work fine?
11:07 < Nakul[m]> Something like ```bin/mlpack_test -t your test suits```
11:12 < Param-29Gitter[m> so for gini-gain (bin/mlpack_test -t mlpack_decision_tree) ?
11:22 < Nakul[m]> ```bin/mlpack_test -t DecisionTreeTest```
11:23 < Nakul[m]> the name of test suits you can find in test files
11:30 < Param-29Gitter[m> i didnt understand. where will i find name of test suits?
11:35 < Nakul[m]> you can see decision_tree_test.cpp where you file find ```BOOST_AUTO_TEST_SUITE`` by running this you will run all the test. if you want just some cases to run you can mention by like ```bin/mlpack_test -t DecisionTreeTest/GiniGainPerfectTest```
11:36 < Nakul[m]> i would suggest to spend some time with boost documentation if you have more doubts : )
12:16 < Param-29Gitter[m> Yes.. thanks :)
12:33 -!- wiking [~wiking@huwico/staff/wiking] has joined #mlpack
15:35 -!- kyrre [uid207859@fsf/member/kyrre] has joined #mlpack
16:38 -!- kyrre [uid207859@fsf/member/kyrre] has quit []
16:39 -!- kyrre [uid207859@fsf/member/kyrre] has joined #mlpack
17:28 -!- UmarJ [~UmarJ@111.68.97.205] has joined #mlpack
17:41 -!- wiking [~wiking@huwico/staff/wiking] has quit [Quit: Leaving...]
18:49 -!- kyrre [uid207859@fsf/member/kyrre] has quit [Quit: Connection closed for inactivity]
20:45 < Nakul[m]> Hey @rcurtin:matrix.org @zoq can we define some set of standard for cmake style I think we are missing that.or can you recommend some best style that we should follow?
20:49 < Nakul[m]> I found this https://github.com/Bagira80/More-Modern-CMake
20:49 < Nakul[m]> I think following such kind of coding style is highly scalable.i mean define everything in its meta file keep different stuff in different files.
20:50 < Nakul[m]> Let me know what you think :)
21:32 -!- ImQ009 [~ImQ009@unaffiliated/imq009] has quit [Quit: Leaving]
--- Log closed Sun Feb 02 00:00:44 2020